Acquiring the Codebase¶
In order to contribute new code or documentation changes, you will need a local copy of the source code which is located on the NuCypher GitHub.
git for version control. Be sure you have it installed.
Here is the recommended procedure for acquiring the code in preparation for contributing proposed changes:
Use GitHub to Fork the nucypher/nucypher repository
Clone your fork’s repository to your local machine
$ git clone https://github.com/<YOUR-GITHUB-USERNAME>/nucypher.git
Change Directories into
Add nucypher/nucypher as an upstream remote
$ git remote add upstream https://github.com/nucypher/nucypher.git
Update your remote tracking branches
$ git remote update
Install the project dependencies: see the Developer Installation Guide
Running the Tests¶
A development installation including the solidity compiler is required to run the tests
There are several test implementations in
nucypher, however, the vast majority
of test are written for execution with
For more details see the Pytest Documentation.
To run the tests:
(nucypher)$ pytest -s
Optionally, to run the full, slow, verbose test suite run:
(nucypher)$ pytest --runslow -s
Making A Commit¶
NuCypher takes pride in its commit history.
When making a commit that you intend to contribute, keep your commit descriptive and succinct. Commit messages are best written in full sentences that make an attempt to accurately describe what effect the changeset represents in the simplest form. (It takes practice!)
Imagine you are the one reviewing the code, commit-by-commit as a means of understanding the thinking behind the PRs history. Does your commit history tell an honest and accurate story?
We understand that different code authors have different development preferences, and others are first-time contributors to open source, so feel free to join our Discord and let us know how we can best support the submission of your proposed changes.
Opening A Pull Request¶
When considering including commits as part of a pull request into nucypher/nucypher, we highly recommend opening the pull request early, before it is finished with the mark “[WIP]” prepended to the title. We understand PRs marked “WIP” to be subject to change, history rewrites, and CI failures. Generally we will not review a WIP PR until the “[WIP]” marker has been removed from the PR title, however, this does give other contributors an opportunity to provide early feedback and assists in facilitating an iterative contribution process.
Pull Request Conflicts¶
As an effort to preserve authorship and a cohesive commit history, we prefer if proposed contributions are rebased over master (or appropriate branch) when a merge conflict arises, instead of making a merge commit back into the contributors fork.
Generally speaking the preferred process of doing so is with an interactive rebase:
Be certain you do not have uncommitted changes before continuing.
Update your remote tracking branches
$ git remote update ... (some upstream changes are reported)
Initiate an interactive rebase over nucypher/nucypher@master
This example specifies the remote name
upstream for the NuCypher organizational repository as
used in the Acquiring the Codebase section.
$ git rebase -i upstream/master ... (edit & save rebase TODO list)
$ git status ... (resolve local conflict) $ git add path/to/resolved/conflict/file.py $ git rebase --continue ... ( repeat as needed )
Push Rebased History
After resolving all conflicts, you will need to force push to your fork’s repository, since the commits are rewritten.
Force pushing will override any changes on the remote you push to, proceed with caution.
$ git push origin my-branch -f
sphinx_rtd_theme are non-standard dependencies that can be installed
pip install -e .[docs] from the project directory.
nucypher is hosted on Read The Docs, and is automatically built without intervention by following the release procedure.
However, you may want to build the documentation html locally for development.
To build the project dependencies locally:
(nucypher)$ cd nucypher/docs/ (nucypher)$ make html
If the build is successful, the resulting html output can be found in
nucypher/docs/build/html/index.html in a web browser is a reasonable next step.
Docker builds are automated as part of the publication workflow on circleCI and pushed to docker cloud. However you may want to build a local version of docker for development.
We provide both a
docker-compose.yml and a
Dockerfile which can be used as follows:
(nucypher)$ docker-compose -f deploy/docker/docker-compose.yml build .
Issuing a New Release¶
bumpversion is a non-standard dependency that can be installed by running
pip install -e .[deployment] or
pip install bumpversion.
Ensure your local tree is based on
master and has no uncommitted changes.
Increment the desired version part (options are
devnum), for example:
(nucypher)$ bumpversion devnum
Ensure you have the intended history and incremented version tag:
(nucypher)$ git log
Push the resulting tagged commit to the originating remote by tag and branch to ensure they remain synchronized.
(nucypher)$ git push origin master && git push origin <TAG>
Push the tag directly upstream by its name to trigger the publication webhooks on CircleCI:
(nucypher)$ git push upstream <TAG>
Monitor the triggered deployment build on CircleCI for manual approval.
Open a pull request with the resulting history in order to update